SWIFT-642 Update examples to use the new BSON API #340
Conversation
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
one thing re these compiling, lgtm otherwise
| try items.insertOne(["sku": "nuts-111", "name": "Pecans", "start": .datetime(currentDate)], session: s1) | ||
| // End Causal Consistency Example 1 | ||
|
|
||
| let client2 = try MongoClient() |
There was a problem hiding this comment.
does this need to be updated too to make these compile?
There was a problem hiding this comment.
we have this ticket open about making sure examples still compile when we do a release, but I wonder if it would be better to make that an evergreen task instead so we catch these things earlier? what do you think?
There was a problem hiding this comment.
Fixed it to compile.
I do think we should incorporate compiling the examples into our evg matrix at least by 1.0, but we do have that circularity issue that I don't really know how to get around. Pre 1.0, we do have the problem that the API in the examples might be vastly different than the API in the latest release, but that will go away real soon so I don't think it is a big issue. I think the API difference is why we were only planning to automate it on releases.
There was a problem hiding this comment.
I added a comment on the ticket about adding this to evg
This PR updates the examples and the readme to use the new API.